forked from nozaq/terraform-aws-secure-baseline
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating from upstream #1
Open
taureanimam
wants to merge
66
commits into
HubTran:main
Choose a base branch
from
nozaq:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add S3 bucket key support * chore: go mod tidy
The `aws_default_subnet` resources will only be created for existing VPC default subnets. This will fix "Default subnet not found" errors when one or multiple default subnets do not exist in the VPC. Fixes: #198
Co-authored-by: nozaq <[email protected]>
…h submodule. (#195) * refactor: use `count` to toggle vpc-baseline * refactor: use `count` to toggle guardduty-baseline * refactor: use `count` to toggle securityhub-baseline * refactor: use `count` to toggle ebs-baseline * refactor: use `count` to toggle analyzer-baseline * refactor: use `count` to toggle config-baseline * refactor: use `count` to toggle cloudtrail-baseline * refactor: use `count` to toggle alarm-baseline * refactor: add migrations
* style: follow the official style conventions * docs: remove modules/resources from README
* chore: add tflint in pre-commit hooks * refactor: remove unused variables * refactor: follow `terraform_standard_module_structure` rule * refactor: define type for variables * chore: add pre-commit checks to CI workflows * chore: apply terraform-doc config to submodules
…m fmt to fail Co-authored-by: Curtis <[email protected]> This is a formatting issue and a slight editing error. (#250)
To conform to IAM.7 in AWS Foundational Security Best Practices.
to avoid the issue in terraform 1.1.3 hashicorp/terraform#30326
member accounts automatically derive the aggregator setting from the master account. fixes: #254
* trigger org cloudtrail with explicit var rather than local * tfdocs * changing var for backwards compatability * check for master account Co-authored-by: Jamie Dick <[email protected]>
BREAKING CHANGE: resources regarding S3 bucket configurations need manual import after upgrade. See `docs/upgrade-1.0.md` for guidance.
Updated the provider requiremenet to avoid the issue in AWS provider v4.1.0 that the validation fails for some AWS regions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nozaq <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
BREAKING CHANGE: this change disables glacier transition rules by default since transitioning small objects is officially not recommended. it can be enabled by setting `var.audit_log_lifecycle_glacier_transition_days` to a positive number. https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-transition-general-considerations.html
It might be a case when iam roles can be created with predefined boundaries. This PR introduce such capabilities by providing permissions_boundary_arn option Currently single permissions_boundary_arn will be applied to all iam_roles provisioned by this module Signed-off-by: Sergiy Kulanov <[email protected]> Co-authored-by: nozaq <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Make audit log bucket access logs bucket name customizable * docs: run terraform-docs Co-authored-by: Kendi Paet <[email protected]> Co-authored-by: nozaq <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several deprecated configs in the current version.
https://tfin.aha.io/develop/features/DEVOPS-119